From 274b17a86047a3c71c4faf406f614b346b40763c Mon Sep 17 00:00:00 2001 From: vabene1111 Date: Mon, 16 Jan 2023 21:20:16 +0100 Subject: [PATCH] improved unit factory and run CI on PR --- .github/workflows/ci.yml | 2 +- cookbook/tests/factories/__init__.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2fdabaf2..644f5ba9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,6 +1,6 @@ name: Continuous Integration -on: [push] +on: [push, pull_request] jobs: build: diff --git a/cookbook/tests/factories/__init__.py b/cookbook/tests/factories/__init__.py index 651d9da0..c4b70e77 100644 --- a/cookbook/tests/factories/__init__.py +++ b/cookbook/tests/factories/__init__.py @@ -97,7 +97,7 @@ class SupermarketCategoryFactory(factory.django.DjangoModelFactory): @register class FoodFactory(factory.django.DjangoModelFactory): """Food factory.""" - name = factory.LazyAttribute(lambda x: faker.sentence(nb_words=3, variable_nb_words=False)) + name = factory.LazyAttribute(lambda x: faker.sentence(nb_words=10)[:128]) plural_name = factory.LazyAttribute(lambda x: faker.sentence(nb_words=3, variable_nb_words=False)) description = factory.LazyAttribute(lambda x: faker.sentence(nb_words=10)) supermarket_category = factory.Maybe( @@ -160,7 +160,7 @@ class RecipeBookEntryFactory(factory.django.DjangoModelFactory): @register class UnitFactory(factory.django.DjangoModelFactory): """Unit factory.""" - name = factory.LazyAttribute(lambda x: faker.word()) + name = factory.LazyAttribute(lambda x: faker.sentence(nb_words=10)[:128]) plural_name = factory.LazyAttribute(lambda x: faker.word()) description = factory.LazyAttribute(lambda x: faker.sentence(nb_words=10)) space = factory.SubFactory(SpaceFactory)