improved random recipe queryset function

This commit is contained in:
vabene1111
2020-11-04 15:09:35 +01:00
parent 8d582548bd
commit 591d185b9d

View File

@ -205,7 +205,8 @@ class RecipeViewSet(viewsets.ModelViewSet, StandardFilterMixin):
permission_classes = [CustomIsShare | CustomIsGuest] # TODO split read and write permission for meal plan guest permission_classes = [CustomIsShare | CustomIsGuest] # TODO split read and write permission for meal plan guest
def get_queryset(self): def get_queryset(self):
queryset = Recipe.objects.all() queryset = self.queryset
internal = self.request.query_params.get('internal', None) internal = self.request.query_params.get('internal', None)
if internal: if internal:
queryset = queryset.filter(internal=True) queryset = queryset.filter(internal=True)
@ -213,9 +214,7 @@ class RecipeViewSet(viewsets.ModelViewSet, StandardFilterMixin):
if random: if random:
queryset = queryset.random(5) queryset = queryset.random(5)
self.queryset = queryset return queryset
return super(RecipeViewSet, self).get_queryset()
# TODO write extensive tests for permissions # TODO write extensive tests for permissions