cgiacofei/Ultimate-Box-Maker
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make it clear Filet is a radius

Browse Source 
Update the comment at the top, which described Filet as a diameter,
which was incorrect for most of the file.

Make it clear that the circle used in foot creation is a radius. It
already was, but provide r= in the argument so it's unambiguous.

SquareHole was treating its filet as a diameter, rather than a radius.
Switch it to treat Filet as a radius. This does make the example square
holes rounder.
This commit is contained in:
Joel Ebel 2018-05-15 16:31:11 -04:00
parent d46a492d0b
commit 43f87b8e70
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
files/U_Box_V104_Test_Cleaned.scad
View File

@ -32,7 +32,7 @@ Thick = 2; //[2:5]
PanelThick = 2;
// - Font Thickness
FontThick = 0.5;
// - Diamètre Coin arrondi - Filet diameter
// - Filet Radius
Filet = 2; //[0.1:12]
// - 0 for beveled, 1 for rounded
Round = 1; // [0:No, 1:Yes]
@ -307,7 +307,7 @@ module foot(FootDia, FootHole, FootHeight) {
translate([FootDia/2 + Filet, Filet, 0]) {
minkowski() {
square(FootHeight);
circle(Filet, $fn=Resolution);
circle(r=Filet, $fn=Resolution);
}
}
}
@ -417,10 +417,10 @@ module SquareHole(OnOff, Sx, Sy, Sl, Sw, Filet) {
echo("SquareHole:", Sx=Sx - CutoutMargin/2, Sy=Sy - CutoutMargin/2,
Sl=Sl + CutoutMargin, Sw=Sw + CutoutMargin, Filet=Filet);
minkowski() {
translate([Sx + Filet/2 - CutoutMargin/2, Sy + Filet/2 - CutoutMargin/2, -PanelThick/2]) {
cube([Sl + CutoutMargin - Filet, Sw + CutoutMargin - Filet, PanelThick]);
translate([Sx + Filet - CutoutMargin/2, Sy + Filet - CutoutMargin/2, -PanelThick/2]) {
cube([Sl + CutoutMargin - Filet*2, Sw + CutoutMargin - Filet*2, PanelThick]);
}
cylinder(PanelThick, d=Filet, $fn=Resolution);
cylinder(PanelThick, r=Filet, $fn=Resolution);
}
}
}